fix: handle nullable payloads #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmd-azeez
requested review from
bhelx,
chrisdickinson and
nilslice
as code owners
mhmd-azeez
force-pushed
the
fix/nullable-payloads
branch
from
5d74e5f to
e6c669c
Compare
bhelx
reviewed
Dec 19, 2024
| return getDefaultForType(property.xtpType!) | ||
| } | ||
|
|
||
| function getDefaultForType(type: XtpNormalizedType): string { |
There was a problem hiding this comment.
i'm kind of confused what's happening here. why does it need a default type? javascript has nulls
bhelx
reviewed
Dec 19, 2024
| <% if (imp.output) { -%> | ||
| const outputMemory = Memory.find(ptr); | ||
| if (isEmpty(outputMemory)) { |
There was a problem hiding this comment.
wouldn't it be the string "null" and not empty?
bhelx
reviewed
Dec 19, 2024
| xtp plugin build --path $PLUGIN_NAME | ||
| echo "testing '$PLUGIN_NAME'..." | ||
| xtp plugin test $PLUGIN_NAME/dist/plugin.wasm --with test.wasm --mock-host mock.wasm | ||
| xtp plugin test $PLUGIN_NAME/dist/plugin.wasm --with test.wasm --mock-host mock.wasm --log-level debug |
|
@bhelx after reading your comments and thinking about it a bit more, i realized this all came up because of I had incorrectly implemented my host function to return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/dylibso/xtp/issues/978
Blocked by dylibso/xtp-bindgen-test#23