Skip to content

fix: normalize enum names #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: normalize enum names #29

merged 1 commit into from
Oct 14, 2024

Conversation

@chrisdickinson
Copy link
Contributor

Normalize names containing invalid identifier characters into the valid identifier character space.

@nilslice
Copy link
Member

nilslice commented Oct 7, 2024

based on our conversation last week, it seems like this is the direction we intend to go.

can you confirm @bhelx?

bhelx
bhelx approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is good for the time being. I would maybe prefer this getting moved to a helper function, but this is fine too as it's readable

@chrisdickinson chrisdickinson merged commit 1fb7126 into main Oct 14, 2024
3 checks passed
@chrisdickinson chrisdickinson deleted the chris/20241002-normalize-enum-names branch October 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilslice nilslice Awaiting requested review from nilslice nilslice is a code owner

1 more reviewer

@bhelx bhelx bhelx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisdickinson @nilslice @bhelx