android: lower floor API version to 28 #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying chicory with
|
| Latest commit: |
ef895bf
|
| Status: | ⚡️ Build in progress... |
evacchi
commented
Feb 20, 2025
|
|
||
| android { | ||
| namespace = "com.dylibso.runtimeTests" | ||
| compileSdk = 35 |
There was a problem hiding this comment.
we don't need to change the compileSdk: this way we are allowed to compile using a recent Java version; minSdk will ensure it works on the lower target (in our case 28). In other words, this is similar to java.version vs java.release
|
as noted earlier in #751, |
Adjust all usages of unsupported APIs. Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
force-pushed
the
android-compat
branch
from
6fe5e5f to
ef895bf
Compare
Deploying chicory with
|
| Latest commit: |
ef895bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdc5655c.chicory.pages.dev |
| Branch Preview URL: | https://android-compat.chicory.pages.dev |
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
Deploying chicory with
|
| Latest commit: |
cd2ae23
|
| Status: | ⚡️ Build in progress... |
Deploying chicory with
|
| Latest commit: |
cd2ae23
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a9f9a1f2.chicory.pages.dev |
| Branch Preview URL: | https://android-compat.chicory.pages.dev |
andreaTP
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
LGTM thanks a lot for this valuable contribution!
cc. @illarionov @yigit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust all usages of unsupported APIs:
InputStream.readAllBytes()->com.dylibso.chicory.wasm.io.InputStreams#readAllBytes(is)List.toArray(T[]::new)->List.toArray(new T[0])toArray(T[]::new)-> `collect(toList()).toArray(new T[0]);collect(Collectors.toUnmodifiableList())->Collections.toUnmodifiableList(...collect(toList()))Notably, the changes only affect
com.dylibso.chicory:wasmbecause build-time codegen does not need to be affected.closes #745