refactoring Instance class #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Oct 29, 2024
| throw new InvalidException("multiple memories"); | ||
| } | ||
| Function<ExternalType, Integer> count = | ||
| (tpe) -> |
There was a problem hiding this comment.
Nit: parens not needed
If you name this t then it fits on one line
andreaTP
force-pushed
the
instance-further-refactoring
branch
from
1b27a25 to
fbe5bfa
Compare
andreaTP
force-pushed
the
instance-further-refactoring
branch
from
fbe5bfa to
a9c9a85
Compare
|
Related: #659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the organic growth happened here and wanted to review this part of the code.
cc. @electrum after this exercise, looking at
initializeshows the "data" that is needed to have "self-contained" instances:elements-> to initialize tablesglobalInitializers-> for globalsdataSegments-> to initialize memoriesWhat they contain?
dataSegments-> containsbyte[]globalInitializers-> are fixed values orglobal.getelements-> is a combination of fixed values andglobal.getwith a slightly more complex "unroll" mechanism