Skip to content

Conversation

@andreaTP
Copy link
Collaborator

Moving the annotation processing stuff under a host-module sub-module.
Including the renames etc.

@andreaTP andreaTP requested review from electrum and evacchi October 16, 2024 09:02
Copy link
Collaborator

@evacchi evacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add 🤔 the one single silly thing I am not really sure about is the package name host.module (because I'm thinking about what could end up under host), but it's not a big deal and I'm fine with it otherwise.

@andreaTP
Copy link
Collaborator Author

I'm not attached to the package name, I'll happily apply any proposed alternative 🙂

Copy link
Collaborator

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also dislike the naming. Using a single lowercase word hostmodule seems to match common practice. This is really just a compound word, not a hierarchy.

What do you expect to call the WASM side of this? wasm-module?

@andreaTP
Copy link
Collaborator Author

What do you expect to call the WASM side of this? wasm-module?

I have an ongoing discussion with @evacchi on it, and progress on it already got stuck on naming a few times 😅

@andreaTP andreaTP force-pushed the split-host-module-annots branch from d11e8a7 to 7eae6b8 Compare October 19, 2024 10:12
@andreaTP andreaTP merged commit 1bec3ef into dylibso:main Oct 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants