Initial simd parsing #575
Merged
Initial simd parsing #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Oct 13, 2024
wasm/src/main/java/com/dylibso/chicory/wasm/types/ValueType.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Test | ||
| public void shouldParseSIMD() throws IOException { | ||
| try (InputStream is = getClass().getResourceAsStream("/wasm/simd_load.0.wasm")) { |
There was a problem hiding this comment.
Where did this file come from? Can we put it in wasm-corpus with sources, like the others?
There was a problem hiding this comment.
This is spec.0.wasm generated from simd_load.wast, I propose that we keep it in this PR and I'll remove as soon as we start running the wast generated tests.
wasm/src/test/java/com/dylibso/chicory/wasm/types/ValueTest.java
Outdated
Show resolved
Hide resolved
wasm/src/test/java/com/dylibso/chicory/wasm/types/ValueTest.java
Outdated
Show resolved
Hide resolved
wasm/src/test/java/com/dylibso/chicory/wasm/types/ValueTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Phillips <david@acz.org>
Co-authored-by: David Phillips <david@acz.org>
Co-authored-by: David Phillips <david@acz.org>
andreaTP
force-pushed
the
simd-parsing
branch
from
b047b03 to
3522b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to get #528 in with reasonable chunks.