Skip to content

chore(deps): bump org.ow2.asm:asm-bom from 9.7 to 9.7.1 #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2024
Merged

chore(deps): bump org.ow2.asm:asm-bom from 9.7 to 9.7.1 #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ac925d
chore(deps): bump org.ow2.asm:asm-bom from 9.7 to 9.7.1
dependabot[bot] Oct 8, 2024
f795570
update approval tests
andreaTP Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aot/src/test/resources/com/dylibso/chicory/approvals/ApprovalTest.verifyFloat.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ public final class com/dylibso/chicory/$gen/CompiledMachine implements com/dylib
ARETURN

public static func_0(Lcom/dylibso/chicory/runtime/Memory;Lcom/dylibso/chicory/runtime/Instance;)V
LDC 0.12345678
LDC 0.123456789012345
LDC 0.12345678F
LDC 0.123456789012345D
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a fix, cc. @electrum

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a fix since this is simply debug output, but the previous output was ambiguous with regard to the constant type, so this is definitely an improvement.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the change here: https://gitlab.ow2.org/asm/asm/-/merge_requests/402

POP2
POP
RETURN
Expand Down
10 changes: 5 additions & 5 deletions aot/src/test/resources/com/dylibso/chicory/approvals/ApprovalTest.verifyI32.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,25 +48,25 @@ public final class com/dylibso/chicory/$gen/CompiledMachine implements com/dylib
POP
LDC 2147483647
POP
LDC -9223372036854775808
LDC -9223372036854775808L
POP2
LCONST_0
POP2
LDC 9223372036854775807
LDC 9223372036854775807L
POP2
LDC -2147483647
POP
LDC 2147483646
POP
LDC -9223372036854775807
LDC -9223372036854775807L
POP2
LDC 9223372036854775806
LDC 9223372036854775806L
POP2
ICONST_M1
POP
ICONST_1
POP
LDC -1
LDC -1L
POP2
LCONST_1
POP2
Expand Down
10 changes: 5 additions & 5 deletions ...c/test/resources/com/dylibso/chicory/approvals/ApprovalTest.verifyI32Renamed.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,25 +48,25 @@ public final class FOO implements com/dylibso/chicory/runtime/Machine {
POP
LDC 2147483647
POP
LDC -9223372036854775808
LDC -9223372036854775808L
POP2
LCONST_0
POP2
LDC 9223372036854775807
LDC 9223372036854775807L
POP2
LDC -2147483647
POP
LDC 2147483646
POP
LDC -9223372036854775807
LDC -9223372036854775807L
POP2
LDC 9223372036854775806
LDC 9223372036854775806L
POP2
ICONST_M1
POP
ICONST_1
POP
LDC -1
LDC -1L
POP2
LCONST_1
POP2
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<maven.dependency.failOnWarning>true</maven.dependency.failOnWarning>

<approvaltests.version>24.8.0</approvaltests.version>
<asm.version>9.7</asm.version>
<asm.version>9.7.1</asm.version>
<commons-io.version>2.17.0</commons-io.version>
<commons-lang.version>3.17.0</commons-lang.version>
<jackson.version>2.18.0</jackson.version>
Expand Down
Loading