No jgit repo downloaders #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.eclipse.jgit:org.eclipse.jgit](https://github.com/eclipse-jgit/jgit) from 6.10.0.202406032230-r to 7.0.0.202409031743-r. - [Commits](eclipse-jgit/jgit@v6.10.0.202406032230-r...v7.0.0.202409031743-r) --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
evacchi
approved these changes
Sep 11, 2024
electrum
reviewed
Sep 12, 2024
| <jackson.version>2.17.2</jackson.version> | ||
| <javaparser.version>3.26.2</javaparser.version> | ||
| <jgit.version>6.10.0.202406032230-r</jgit.version> | ||
| <zip4j.version>2.11.5</zip4j.version> |
There was a problem hiding this comment.
What features is java.util.zip.ZipFile missing?
There was a problem hiding this comment.
None afaik, it was just much more convenient to use a higher level library (less LOCs, maintenance etc.).
There was a problem hiding this comment.
@electrum the dependency is not exposed to the end user and only used internally in Maven plugins, do you think we should go the extra mile to remove it?
There was a problem hiding this comment.
I have no problem with this. I was just curious if these zip files use a newer format or something that the JDK does not support.
There was a problem hiding this comment.
Sorry, I should have clarified that this was just a question and not a blocking concern about the PR.
electrum
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JGit dropped support for Java 11 with version 7.
It's convenient, but we don't really need it, here I'm replacing it using this feature of GitHub.
Tested on Windows in CI here
Supersede #522