-
Notifications
You must be signed in to change notification settings - Fork 59
[POC] Use the AOT compiled code instead of MH #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice work! Allowing to ship AOT compiled code with the application makes sense for cases where the WASM is static. Some comments:
|
~~On top of: dylibso#495 (needs to be merged first)~~ Follow up from: dylibso#494
Follow up from dylibso#494
924a3f9 to
9702143
Compare
|
Done another iteration, rebasing on top of the improvements already merged and mostly tackling:
Now the Notes:
Issues: Question: |
I quickly investigated again, and it looks like the // this goes in generated-sources
interface MyInterface {
static MyInterface create() { return new GeneratedBytecode(); }
// stubs go here...
}
// we don't care where this goes
class GeneratedBytecode implements MyInterface { ... }this might workaround that problem (although the IDE might still complain about |
that's "kinda" what I'm doing already, but I have to admit that the experience is still poor IMHO 😢 |
|
I searched around and it sounds like using a separate module is the only way to make the IDE work. While this not ideal, I don't think it is a blocker for adoption. This has benefits from a build perspective, because the module would only need to be rebuilt when the WASM binary changes or when Chicory is updated. |
|
Superseded by #556 |
Opening this PR in draft as a reference for further discussion on the future of the AOT compiler(and how it should be used).