Skip to content

[ENG-1188] Move parent subaccount transfer filtering to SQL to respect limit parameter #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[ENG-1188] Move parent subaccount transfer filtering to SQL to respect limit parameter #3234

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f01efaa
New SQL query for parentSubaccount transfer endpoint
davidli1997 Oct 30, 2025
100d95a
Add transfer table tests
davidli1997 Oct 30, 2025
c6c2278
Merge remote-tracking branch 'origin' into davidli/transfers_endpoint
davidli1997 Oct 31, 2025
27a2ba6
New transfer parentSubaccountNumber endpoint
davidli1997 Nov 5, 2025
33ba5b4
Done testing in staging
davidli1997 Nov 5, 2025
1e63100
Remove unused definition
davidli1997 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/indexer-build-and-push-dev-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on: # yamllint disable-line rule:truthy
- main
- 'release/indexer/v[0-9]+.[0-9]+.x' # e.g. release/indexer/v0.1.x
- 'release/indexer/v[0-9]+.x' # e.g. release/indexer/v1.x
- davidli/transfers_endpoint
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove development branch trigger before merging.

Same as in the protocol workflow, this development branch trigger should be removed before merging to main.

Apply this diff:

       - 'release/indexer/v[0-9]+.[0-9]+.x'  # e.g. release/indexer/v0.1.x
       - 'release/indexer/v[0-9]+.x'  # e.g. release/indexer/v1.x
-      - davidli/transfers_endpoint
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- davidli/transfers_endpoint
- 'release/indexer/v[0-9]+.[0-9]+.x' # e.g. release/indexer/v0.1.x
- 'release/indexer/v[0-9]+.x' # e.g. release/indexer/v1.x
🤖 Prompt for AI Agents 
.github/workflows/indexer-build-and-push-dev-staging.yml lines 9-9: remove the
development branch trigger entry currently listed as "-
davidli/transfers_endpoint" so the workflow no longer runs on that dev branch;
delete that line (or remove that branch from the branches array) and ensure YAML
indentation remains valid so the workflow only triggers on the intended branches
for main/staging.

# TODO(DEC-837): Customize github build and push to ECR by service with paths

jobs:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/protocol-build-and-push-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on: # yamllint disable-line rule:truthy
- main
- 'release/protocol/v[0-9]+.[0-9]+.x' # e.g. release/protocol/v0.1.x
- 'release/protocol/v[0-9]+.x' # e.g. release/protocol/v1.x
- davidli/transfers_endpoint
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove development branch trigger before merging.

Remove this development branch trigger before merging.

Apply this diff:

       - 'release/protocol/v[0-9]+.[0-9]+.x'  # e.g. release/protocol/v0.1.x
       - 'release/protocol/v[0-9]+.x'  # e.g. release/protocol/v1.x
-      - davidli/transfers_endpoint
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- davidli/transfers_endpoint
🤖 Prompt for AI Agents 
.github/workflows/protocol-build-and-push-snapshot.yml around line 9: remove the
development branch trigger entry "davidli/transfers_endpoint" from the workflow
triggers so the CI does not run on that branch after merging; update the
workflow file to delete that line (or remove the branch from the branches list)
and commit the change so the workflow no longer triggers for the development
branch.


jobs:
build-and-push-snapshot-dev:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/protocol-build-and-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on: # yamllint disable-line rule:truthy
- main
- 'release/protocol/v[0-9]+.[0-9]+.x' # e.g. release/protocol/v0.1.x
- 'release/protocol/v[0-9]+.x' # e.g. release/protocol/v1.x
- davidli/transfers_endpoint
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove development branch trigger before merging.

The branch davidli/transfers_endpoint is a personal development branch and should not be committed to the workflow configuration. This will cause unnecessary CI runs after the PR is merged to main.

Apply this diff to remove the development branch trigger:

       - 'release/protocol/v[0-9]+.[0-9]+.x'  # e.g. release/protocol/v0.1.x
       - 'release/protocol/v[0-9]+.x'  # e.g. release/protocol/v1.x
-      - davidli/transfers_endpoint
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- davidli/transfers_endpoint
- 'release/protocol/v[0-9]+.[0-9]+.x' # e.g. release/protocol/v0.1.x
- 'release/protocol/v[0-9]+.x' # e.g. release/protocol/v1.x
🤖 Prompt for AI Agents 
In .github/workflows/protocol-build-and-push.yml around line 9, the workflow
currently lists a personal development branch (davidli/transfers_endpoint) in
its branch trigger; remove that branch entry so the workflow no longer triggers
on that personal branch (either delete the line or replace it with the intended
protected branch names such as main or release branches), then save the workflow
to prevent CI from running for the development branch after merge.


jobs:
build-and-push-dev:
Expand Down
Loading
Loading