[MDAPI-249] [C++] Hide transitive dependencies. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed target linking from PUBLIC to PRIVATE for better encapsulation of dependencies. Also cleaned up the documentation CMake file by removing unused comments and redundant settings.
Replaced specific manager classes (e.g., DXFeedManager, DXEndpointManager) with a generic EntityManager template. Simplified ApiContext by removing AddManagerMixin logic and unused specific manager definitions. This change enhances code maintainability and consistency across entity management.
Reorganized includes to remove unused manager headers and added EntityManager where needed. Moved the destructor of ApiContext from private to public to ensure proper cleanup functionality. These changes improve code clarity and maintainability.
Compatibility with CMake versions below 3.5 was removed, causing build issues. This update ensures proper functionality with supported CMake versions and resolves compatibility errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed target linking from PUBLIC to PRIVATE for better encapsulation of dependencies. Also cleaned up the documentation CMake file by removing unused comments and redundant settings.