Enable ASAN/UBSAN integration and refactor linking logic #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ASAN/UBSAN flags to the build configuration for enhanced runtime checks. Introduced a reusable `LinkAsanUbsan` function to centralize and simplify target linking. Updated relevant build and test scripts to use the new function.
Update LinkAsanUbsan to use the targetName parameter instead of PROJECT_NAME. This ensures the correct target is configured for sanitizers, improving flexibility and correctness.
Split ASAN and UBSAN configurations into separate options and functions. Updated build matrix and CMake logic to handle each sanitizer independently, improving flexibility and clarity.
Added sanitizers to workflow matrix names for better clarity. Adjusted test step to only run if the workflow is not canceled. Minor cleanup of formatting for consistency.
Added `continue-on-error` to ensure the pipeline proceeds despite test failures. Updated the ctest command to include `--output-on-failure` for better debugging and `--parallel` to specify the number of cores for faster execution.
Updated build workflows to exclude UBSAN on Windows and streamlined the ctest command. Added support for AddressSanitizer on Windows in CMake, including necessary compiler definitions, while removing unused VS-specific ASAN option.
The conditional check excluding UBSAN on Windows was removed as it is no longer necessary. This simplifies the workflow configuration and ensures consistency across builds. All relevant configurations will now be executed without exclusion.
Added the `--output-on-failure` flag to the ctest command in the GitHub Actions workflow. This ensures that test failures provide detailed output, improving debugging efficiency.
Removed `#define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN` from all test files and introduced a central `main.cpp` for running tests. Updated CMake configuration to link the new shared main with test executables. Adjusted signal handling and stack trace features in the new `main.cpp` for better test execution control.
Added a copyright header with license information to the test file. Also reordered and grouped include statements for improved readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ASAN/UBSAN flags to the build configuration for enhanced runtime checks. Introduced a reusable
LinkAsanUbsanfunction to centralize and simplify target linking. Updated relevant build and test scripts to use the new function.