Skip to content
This repository was archived by the owner on Feb 11, 2024. It is now read-only.

Update VerificationController.php #126

Closed
wants to merge 1 commit into from

Conversation

barchard
Copy link
Contributor

Add better scalability for large databases with API requests.

I'll admit, I have not tested this as I don't have a dev environment set up. I followed the published Statamic docs.

Add better scalability for large databases with API requests
@barchard
Copy link
Contributor Author

@duncanmcclean do you mind advising and help get this sorted? this is new to me and trying to make this API scalable. thanks

Copy link
Owner

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to test this yet and won't be able to until the weekend at the earliest.

However, in looking through your code, there's a few things I've spotted that will need to be changed. You'll also see that the test suite isn't passing which will need to be fixed.

If you need to use these changes urgently in your application, you can use composer patches.

@duncanmcclean
Copy link
Owner

I've opened a new PR (#128) for this as for some reason GitHub Desktop wouldn't push to your fork.

Some of the changes I've made:

  • I've split the code into two queries: one for flat-file orders and another for database orders. This means we can use different ->where statements.
  • I've added separate tests for using the VerificationController against database orders.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Released as part of v5.0.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants