Skip to content

Multiple small NTP improvements #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2025
Merged

Conversation

vkraucunas
Copy link
Contributor

@vkraucunas vkraucunas commented Jun 19, 2025

Asana Task/Github Issue: <!-- Link to Asana Task/Github Issue —>

Description

Fixes/improves a few things on the NTP

  • Swaps in new icon for the ProtectionStats (for the Asana task listed above)
  • Adds i18n for numbers in the Protections widget
  • Improves the URL search params docs

Testing Steps

  • Demo
    • Is set to Portuguese, but check out other locales too
    • Check out the icon in the widget
  • Buzz through the readme updates

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@vkraucunas vkraucunas requested review from shakyShane, mgurgel and a team as code owners June 19, 2025 01:09
Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 3942312
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68543066a3bc3a000879339b
😎 Deploy Preview https://deploy-preview-1758--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jun 19, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jun 19, 2025

[Beta] Generated file diff

Time updated: Thu, 19 Jun 2025 15:45:27 GMT

Android
    - android/pages/duckplayer/dist/index.js

File has changed

Integration
    - integration/pages/duckplayer/dist/index.js
  • integration/pages/example/dist/index.js
  • integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/onboarding/dist/index.js
  • integration/pages/release-notes/dist/index.js
  • integration/pages/special-error/dist/index.js

File has changed

Removed Files
    - integration/pages/new-tab/icons/shield-green.svg
  • windows/pages/new-tab/icons/shield-green.svg
  • dist/pages/new-tab/icons/shield-green.svg

❌ File only exists in old changeset

Windows
    - windows/pages/duckplayer/dist/index.js
  • windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/onboarding/dist/index.js
  • windows/pages/release-notes/dist/index.js
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/index.html

File has changed

Apple
    - dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html
  • dist/pages/history/dist/index.js
  • dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/onboarding/dist/index.js
  • dist/pages/release-notes/dist/index.js
  • dist/pages/special-error/dist/index.js
  • dist/pages/special-error/index.html

File has changed

New Files
    - integration/pages/new-tab/icons/Shield-Check-Color-16.svg
  • windows/pages/new-tab/icons/Shield-Check-Color-16.svg
  • dist/pages/new-tab/icons/Shield-Check-Color-16.svg

❌ File only exists in new changeset

@vkraucunas vkraucunas force-pushed the vkraucunas/i18n-numbers-ntp branch from 8e000e2 to 3942312 Compare June 19, 2025 15:44
@vkraucunas vkraucunas merged commit c4fbb4d into main Jun 19, 2025
16 checks passed
@vkraucunas vkraucunas deleted the vkraucunas/i18n-numbers-ntp branch June 19, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants