Skip to content

Add ui tests for missing UniquePtr and CxxVector impls with aliases #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

sbrocket
Copy link
Contributor

@sbrocket sbrocket commented Oct 3, 2020

This is a single commit on top of #308 to add some missing ui tests. (If only Github would add chains of pull requests...) I'll rebase as review proceeds on #308.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close this as well since the PR this depends on was closed, but I've cherry-picked the one commit across to #354 and we'll make sure to pick it up as part of closing #297. Thanks!

@dtolnay dtolnay closed this Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants