Disable std::vector::reserve when not move constructible #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from /usr/include/c++/13/vector:65,
from target/debug/build/cxx-test-suite-fd93725a6af072af/out/cxxbridge/include/rust/cxx.h:16,
from target/debug/build/cxx-test-suite-fd93725a6af072af/out/cxxbridge/crate/tests/ffi/tests.h:2,
from target/debug/build/cxx-test-suite-fd93725a6af072af/out/cxxbridge/sources/tests/ffi/lib.rs.cc:1:
/usr/include/c++/13/bits/stl_uninitialized.h: In instantiation of 'constexpr bool std::__check_constructible() [with _ValueType = tests::Unmovable; _Tp = tests::Unmovable&&]':
/usr/include/c++/13/bits/stl_uninitialized.h:182:4: required from '_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = move_iterator<tests::Unmovable*>; _ForwardIterator = tests::Unmovable*]'
/usr/include/c++/13/bits/stl_uninitialized.h:373:37: required from '_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, allocator<_Tp>&) [with _InputIterator = move_iterator<tests::Unmovable*>; _ForwardIterator = tests::Unmovable*; _Tp = tests::Unmovable]'
/usr/include/c++/13/bits/stl_vector.h:1622:35: required from 'std::vector<_Tp, _Alloc>::pointer std::vector<_Tp, _Alloc>::_M_allocate_and_copy(size_type, _ForwardIterator, _ForwardIterator) [with _ForwardIterator = std::move_iterator<tests::Unmovable*>; _Tp = tests::Unmovable; _Alloc = std::allocator<tests::Unmovable>; pointer = tests::Unmovable*; size_type = long unsigned int]'
/usr/include/c++/13/bits/vector.tcc:86:36: required from 'void std::vector<_Tp, _Alloc>::reserve(size_type) [with _Tp = tests::Unmovable; _Alloc = std::allocator<tests::Unmovable>; size_type = long unsigned int]'
target/debug/build/cxx-test-suite-fd93725a6af072af/out/cxxbridge/sources/tests/ffi/lib.rs.cc:2829:13: required from here
/usr/include/c++/13/bits/stl_uninitialized.h:90:56: error: static assertion failed: result type must be constructible from input type
90 | static_assert(is_constructible<_ValueType, _Tp>::value,
| ^~~~~
/usr/include/c++/13/bits/stl_uninitialized.h:90:56: note: 'std::integral_constant<bool, false>::value' evaluates to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1645.