Add gen-sig script #193
Add gen-sig script #193
Conversation
There was a problem hiding this comment.
Very promising! ✨
I've wanted to marry fxn's inline annotation convention with rbs sigs for a long time, but never made much progress on it. Looks like Soutaro had a similar idea.
My code review comments are mostly just nitpicks. As for how to integrate this, probably a precommit hook. We could potentially do something like repo-sync, which only makes commits if its templates generate changes, but that would take some effort.
aaronmallen
force-pushed
the
aa/signatures
branch
3 times, most recently
from
307758b to
6f267a4
Compare
This is adds the `gen-sig` script to generate signatures as well as a signatures for the project.
aaronmallen
force-pushed
the
aa/signatures
branch
from
6f267a4 to
31b87b8
Compare
|
@alassek how do we feel about reducing the scope of this work a bit... I'm running into some walls where things aren't documented and I'm having a hard time groking their shapes. What if we reduce the scope of this PR to incorporating the script and follow up with more refined signatures in future PRs? |
|
closing in favor of #194 |
|
@aaronmallen by no means would I expect you to annotate the whole thing. Just the documented public API would be sufficient. |
2 participants
This is adds the
gen-sigscript to generate signatures as well as a signatures for the project.