Fix/reduce sync requests #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The client makes too many network requests by default. This PR aims to reduce the total number of requests made by the client to only those being used by the caller.
currently the client provides one method to subscribe to all markets and oracles
this PR makes it more flexible allowing caller to decide the necessary markets.
Changes
external
subscribe
method into parts:subscribe_markets
,subscribe_oracles
,subscribe_block_hashes
subscribe_markets
andsubscribe_oracles
receive a list of markets to subscribe forMarketId
struct rather than oracle pubkeystry_
e.g.try_get_oracle_price
to distinguish from async methodsinternal
if GPA is needed likely for some generic filler then that can be re-added later
Other
closes #60