add grpc backed EventSubscriber and example #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordy25519
reviewed
May 9, 2025
crates/src/event_subscriber.rs
Outdated
|
|
||
| let raw_event_tx_clone = raw_event_tx.clone(); | ||
| grpc.on_transaction(Box::new(move |tx_update: TransactionUpdate| { | ||
| raw_event_tx_clone.try_send(tx_update).unwrap(); |
There was a problem hiding this comment.
is it possible to handle the update inline here? maybe then can pass TransactionUpdate by ref
Suggested change
| raw_event_tx_clone.try_send(tx_update).unwrap(); | |
| let start = std::time::Instant::now(); | |
| let slot = event.slot; | |
| self.process_log(event).await; | |
| let elapsed = start.elapsed(); | |
| debug!(target: "grpc", "transaction slot: {}, len: {} callbacks took {:?}", slot, raw_event_rx.len(), elapsed); |
There was a problem hiding this comment.
couldn't get this to work since process_log is async. Maybe i should change grpc.on_transaction to take async callbacks?
Comment on lines
+409
to
+429
| let tx = match tx_update.transaction { | ||
| Some(ref tx) => tx, | ||
| None => { | ||
| warn!(target: "grpc", "empty transaction update: {tx_update:?}"); | ||
| continue; | ||
| } | ||
| }; | ||
| let transaction = match tx.transaction { | ||
| Some(ref tx) => tx, | ||
| None => { | ||
| warn!(target: "grpc", "empty transaction update: {tx_update:?}"); | ||
| continue; | ||
| } | ||
| }; | ||
| let meta = match tx.meta { | ||
| Some(ref meta) => meta, | ||
| None => { | ||
| warn!(target: "grpc", "empty transaction meta: {tx_update:?}"); | ||
| continue; | ||
| } | ||
| }; |
There was a problem hiding this comment.
wondering what happens if valid tx but has no meta? not sure if that'll happen in practice
There was a problem hiding this comment.
yeah i dont think it'll happen in practice, but i feel it's safer to check. I saw a surprising number of tx logs without signatures (11111...) from websocket, but none were like that from grpc
jordy25519
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventSubscriber::subscribe_grpcto start anEventSubscriberbacked by yellowstone grpccloses #154