Skip to content

Refactor visibility of methods and fields across various modules #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025

Conversation

DecentralizedDev
Copy link
Contributor

Quick list of methods / field that are likely going to be useful for someone in the future if they are pub.

Copy link
Collaborator

@jordy25519 jordy25519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a couple places where feature flags are needed.
may make sense to use getter methods for that

@DecentralizedDev
Copy link
Contributor Author

Made it a conditional field for now. Getter is also possible, what do you prefer?

@jordy25519
Copy link
Collaborator

Made it a conditional field for now. Getter is also possible, what do you prefer?

I'd prefer to use getters so there'll be less #[cfg blocks

@DecentralizedDev
Copy link
Contributor Author

Should be fine now @jordy25519

@jordy25519
Copy link
Collaborator

Should be fine now @jordy25519

code lgtm.
CI complaining, needs a cargo fmt

@DecentralizedDev
Copy link
Contributor Author

@jordy25519 should be good to go

@jordy25519 jordy25519 merged commit 3c69c62 into drift-labs:main Apr 4, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants