[#416] Added When I visit the :vocabulary_machine_name term delete page with the name :term_name
#420
Conversation
|
""" WalkthroughThe Drupal taxonomy trait was enhanced with new methods to visit term edit and delete pages by vocabulary and term name. Corresponding Behat steps were renamed for clarity and a new step for visiting the term delete page was added. Feature tests were updated with renamed steps and new scenarios to verify delete page access and error handling. Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🪛 markdownlint-cli2 (0.17.2)STEPS.md2489-2489: Inline HTML (MD033, no-inline-html) 2489-2489: Inline HTML (MD033, no-inline-html) 2491-2491: Inline HTML (MD033, no-inline-html) 2493-2493: Inline HTML (MD033, no-inline-html) 2493-2493: Inline HTML (MD033, no-inline-html) 2502-2502: Inline HTML (MD033, no-inline-html) 2503-2503: Inline HTML (MD033, no-inline-html) 2503-2503: Inline HTML (MD033, no-inline-html) 2505-2505: Inline HTML (MD033, no-inline-html) 2507-2507: Inline HTML (MD033, no-inline-html) 2507-2507: Inline HTML (MD033, no-inline-html) 2516-2516: Inline HTML (MD033, no-inline-html) 2517-2517: Inline HTML (MD033, no-inline-html) 2517-2517: Inline HTML (MD033, no-inline-html) 2519-2519: Inline HTML (MD033, no-inline-html) 2521-2521: Inline HTML (MD033, no-inline-html) 2521-2521: Inline HTML (MD033, no-inline-html) 🔇 Additional comments (5)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
STEPS.md(1 hunks)src/Drupal/TaxonomyTrait.php(1 hunks)tests/behat/features/drupal_taxonomy.feature(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
STEPS.md
2488-2488: Inline HTML
Element: details
(MD033, no-inline-html)
2489-2489: Inline HTML
Element: summary
(MD033, no-inline-html)
2489-2489: Inline HTML
Element: code
(MD033, no-inline-html)
2491-2491: Inline HTML
Element: br
(MD033, no-inline-html)
2493-2493: Inline HTML
Element: br
(MD033, no-inline-html)
2493-2493: Inline HTML
Element: br
(MD033, no-inline-html)
🔇 Additional comments (1)
STEPS.md (1)
2488-2500: LGTM! Well-documented step addition.The documentation follows the established format and provides a clear example. The static analysis warnings about inline HTML can be ignored as this is the standard format used throughout this documentation file.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
2488-2488: Inline HTML
Element: details(MD033, no-inline-html)
2489-2489: Inline HTML
Element: summary(MD033, no-inline-html)
2489-2489: Inline HTML
Element: code(MD033, no-inline-html)
2491-2491: Inline HTML
Element: br(MD033, no-inline-html)
2493-2493: Inline HTML
Element: br(MD033, no-inline-html)
2493-2493: Inline HTML
Element: br(MD033, no-inline-html)
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
tests/behat/features/drupal_taxonomy.feature (2)
234-246: Past review suggestion has been implemented.This negative test scenario for non-existing vocabulary was previously suggested and has now been correctly implemented.
248-260: Past review suggestion has been implemented.This negative test scenario for non-existing term was previously suggested and has now been correctly implemented.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/Drupal/TaxonomyTrait.php(1 hunks)tests/behat/features/drupal_taxonomy.feature(1 hunks)
🔇 Additional comments (1)
tests/behat/features/drupal_taxonomy.feature (1)
226-232: Well-structured happy path test.The test scenario effectively validates the delete functionality by creating a term, deleting it, and verifying it no longer exists. The implementation follows the established testing patterns in this feature file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 80.22% 80.23% +0.01%
==========================================
Files 29 29
Lines 2038 2029 -9
==========================================
- Hits 1635 1628 -7
+ Misses 403 401 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/Drupal/TaxonomyTrait.php(2 hunks)
🔇 Additional comments (1)
src/Drupal/TaxonomyTrait.php (1)
246-280: Excellent implementation following established patterns.The
taxonomyDeleteTermmethod implementation looks great! It addresses all the previous feedback:
- ✅ Includes vocabulary existence validation (lines 256-259)
- ✅ Uses consistent
\RuntimeExceptionfor error handling- ✅ Follows the same term selection pattern as other methods using
taxonomyLoadMultiple()and selecting the last created term- ✅ Includes proper documentation with @code example and @when annotation
- ✅ Validates both vocabulary and term existence before attempting deletion
The implementation is consistent with other methods in the trait and provides robust error handling.
nsineok
force-pushed
the
feature/416-delete-term
branch
from
15473cd to
4cb27d4
Compare
nsineok
added
the
PR: Needs review
AlexSkrypnyk
force-pushed
the
feature/416-delete-term
branch
from
4cb27d4 to
0220bb4
Compare
|
@coderabbitai resolve |
✅ Actions performedComments resolved. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
AlexSkrypnyk
changed the title
When I visit the :vocabulary_machine_name term delete page with the name :term_name
Closes #416
Summary by CodeRabbit
Documentation
Tests