- 
                Notifications
    You must be signed in to change notification settings 
- Fork 526
Temporary solution for _TZ3000_qeuvnohg #8179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR aims to override the PR at dresden-elektronik#7012, to make these MAINS device(s) available, but also to mitigate the danger inherent to the MAINS type in that PR. This is a temporary solution until Mains switches are handled better in Phoscon GUI. Note that in above discussion it was argued, that security is the job for the API client. Since Phoscon GUI does not yet handle mains specifically, I suggest to merge this PR in the meantime, having: - no `lights:state/on` property (disable switch) - `"type": "$TYPE_SMART_PLUG"`, because it currently fits better with the Phoscon GUI. The remarks by @BabaIsYou for the similar devices (`"_TZ3000_ky0fq4ho","_TZ3000_8bxrzyxz"`) are in this PR too, though untested by myself. Please DEVs, review/change the timings to your likings. Thanks. If this gets merged, then dresden-elektronik#7012 is not valid anymore. cheers
| Hello @labor4 , the formatting was not correct, the duplicate uuid was removed and the intervals were optimized a bit. | 
| @mattreim | 
| Hey @labor4, thanks for your pull request! Tip Modified bundles can be downloaded here. DDB changesModified
 ValidationTip Everything is fine ! 🕧 Updated for commit 2ae01be | 
| is now and other .... | 
| @labor4 , replace all  | 
| 
 I can check and see what happens in Phoscon GUI if the "lights/TYPE_SMART_PLUG" section is missing. It's probably going to sort it into "sensors". Frankly I wouldn't care, since I consider this device's lights-feature a bug to begin with. I think this device should be a meter and nothing more, but this PR is intended as a heads-up for the GUI to reflect Mains, so incomplete as-intended. What is your preference? Shall we convert this switch into a sensor-only? I now put the note into the  | 
| 
 Not at this place, and no other fields for me, but don't worry for this. If this device don't have state/on why do you want to create a "light" entry ? | 
| @Smanar Going to make some tests the next days. cheers | 
| Yeah don't worry for that, some router (making only routing) have a DDF to force them visible in the API, but your device will be visible in "sensors" part, so no problem for me, can be removed. | 
Phoscon 2.28.1 cannot handle this commit, without a lights section.
| Phoscon GUI cannot handle these sensors if they are not part of a SMARTPLUG. The latest commit features sensors-only. Thanks. | 
| Ha yes, it's a problem for phoscon, but not third app. | 
| Yeah I guess I could get it from the API, but this is a simple setup with no other integration/automation. If you can send Phoscon a note with some interest in this, much obliged from my side. I don't know where they reside these days. Their repo seems abandonned. | 
| I m trying on the forum https://forum.phoscon.de/t/support-for-power-measurement-sensor/6296 But to be sure, you have checked on "sensor" page on Phoscon ? not "light". Edit: | 
| thanks! for the record: my check showed, that the sensor page would show only the temperature measurement, but not power consumption (yes surprise this thing has a thermal sensor too😂). the smartplug page shows light and power consumption, but not temperature. anyways thanks for your effort | 
| Yeah I think it will be a problem, because Phoscon display "by device", so a device need to be a "light" or a "sensor", so they are doing "magic" to mix data, and not possible for all situations. | 
| i sent dresden-elektronik a mail with explanations and a request to either 
 they replied they‘d take a look at it. | 
This PR aims to override the PR at #7012, to make these MAINS device(s) available, but also to mitigate the danger inherent to the MAINS type in that PR.
This is a temporary solution until Mains switches are handled better in Phoscon GUI.
Note that in above discussion it was argued, that security is the job for the API client. Since Phoscon GUI does not yet handle mains specifically, I suggest to merge this PR in the meantime, having:
lights:state/onproperty (disable switch)"type": "$TYPE_SMART_PLUG", because it currently fits better with the Phoscon GUI.The remarks by @BabaIsYou for the similar devices (
"_TZ3000_ky0fq4ho","_TZ3000_8bxrzyxz") are in this PR too, though untested by myself.Please DEVs, review/change the timings to your likings. Thanks.
If this gets merged, then #7012 is not valid anymore.
cheers