Skip to content

[add transalations for other languages][good first issue] #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

[add transalations for other languages][good first issue] #421

merged 5 commits into from
Apr 24, 2025

Conversation

MrAhmadHassan
Copy link
Contributor

pk-pa (Pakistani punjabi) language support added

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2025

@MrAhmadHassan is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

1ilit
1ilit requested changes Apr 23, 2025
View reviewed changes
Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to import it in https://github.com/drawdb-io/drawdb/blob/main/src/i18n/i18n.js

src/i18n/locales/pk-pa.js Outdated
const punjabi = {
name: "Punjabi",
native_name: "پنجابی",
code: "pkpa",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the code to pa-PK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1ilit
I have done the requested changes please review the code .
Thanks

@MrAhmadHassan MrAhmadHassan requested a review from 1ilit April 24, 2025 16:53
1ilit
1ilit requested changes Apr 24, 2025
View reviewed changes
Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Youll have to remove the old file for it to work, the builds are failing

@MrAhmadHassan MrAhmadHassan requested a review from 1ilit April 24, 2025 17:06
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 5:36pm

1ilit
1ilit approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@1ilit 1ilit merged commit f448c8c into drawdb-io:main Apr 24, 2025
4 checks passed
ewqazxc pushed a commit to ewqazxc/drawdb that referenced this pull request Apr 28, 2025
@MrAhmadHassan @ewqazxc
[add transalations for other languages][good first issue] (drawdb-io#421
74c6fb2 
)

* pk-pa language support added

* changed the code to pa-PK and imported the module to src/i18n/i18n.js

* Removed old file causing build issue

* staging changes

* staging changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ilit 1ilit 1ilit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrAhmadHassan @1ilit