metric: treat io.EOF as successful upload, not an error #2004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
internal/metric/metric.go
file, focusing on error handling and dependency updates. The changes improve the robustness of metrics tracking by accounting for additional error scenarios and updating imports.Error handling improvements:
TransferCompleted
function to incrementtotalUploads
even when the error isio.EOF
, ensuring proper metrics tracking for completed transfers despite this specific error condition.Dependency updates:
errors
andio
packages to support the new error handling logic in theTransferCompleted
function.Uploads that end with io.EOF are now considered successful and no longer increment the upload error metric. This aligns metric reporting with Go convention, where io.EOF indicates normal completion rather than an error.Checklist for Pull Requests