Skip to content

Conversation

fatelei
Copy link
Contributor

@fatelei fatelei commented Sep 5, 2025

Overview

Please briefly describe the changes your pull request makes.

Related Issues

#1697

Change Details

Please describe your changes in detail:

Test Results

If you have any relevant screenshots or videos that can help illustrate your changes, please add them here.

Change Type

Please select the type of change your pull request relates to:

  • Bug Fix
  • Feature Addition
  • Documentation Update
  • Code Refactoring
  • Performance Improvement
  • Other (please describe)

Self-Checklist

Before submitting a pull request, please ensure you have completed the following:

  • I have run a code style check and addressed any warnings/errors.
  • I have added appropriate comments to my code (if applicable).
  • I have updated the documentation (if applicable).
  • I have written appropriate unit tests.

@fatelei fatelei requested a review from a team as a code owner September 5, 2025 10:13
@fatelei fatelei requested review from hsiangkao, imeoer and power-more and removed request for a team September 5, 2025 10:13
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 64.94845% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.60%. Comparing base (7e912b6) to head (79a882c).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
api/src/http_endpoint_common.rs 0.00% 10 Missing ⚠️
service/src/upgrade.rs 0.00% 7 Missing ⚠️
src/bin/nydusd/api_server_glue.rs 0.00% 7 Missing ⚠️
service/src/fusedev.rs 0.00% 4 Missing ⚠️
service/src/fs_service.rs 0.00% 3 Missing ⚠️
src/lib.rs 95.45% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   55.58%   55.60%   +0.01%     
==========================================
  Files         197      197              
  Lines       53109    53219     +110     
  Branches    44441    44540      +99     
==========================================
+ Hits        29523    29590      +67     
- Misses      22117    22154      +37     
- Partials     1469     1475       +6     
Files with missing lines Coverage Δ
api/src/http.rs 0.00% <ø> (ø)
api/src/http_handler.rs 53.08% <ø> (ø)
service/src/fs_service.rs 41.82% <0.00%> (-0.49%) ⬇️
src/lib.rs 88.88% <95.45%> (+88.88%) ⬆️
service/src/fusedev.rs 0.00% <0.00%> (ø)
service/src/upgrade.rs 63.31% <0.00%> (-1.47%) ⬇️
src/bin/nydusd/api_server_glue.rs 0.00% <0.00%> (ø)
api/src/http_endpoint_common.rs 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imeoer
Copy link
Collaborator

imeoer commented Sep 10, 2025

Hi @fatelei, thanks for the PR, but nydusd failover and upgrade automation is already covered in these PRs: :(

#1740
containerd/nydus-snapshotter#653

@fatelei fatelei closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants