Skip to content

feat: remove span in get piece #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 4, 2025

Description

This pull request includes updates to the Cargo.toml file to increment the version of the package and its dependencies, as well as a minor change in the dragonfly-client/src/resource/piece.rs file to remove the #[instrument(skip_all)] attribute from the get method.

Version updates:

  • Cargo.toml: Incremented the package version from 0.2.31 to 0.2.32 and updated all related dependencies to match the new version. [1] [2]

Code cleanup:

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jun 4, 2025
@gaius-qi gaius-qi self-assigned this Jun 4, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner June 4, 2025 09:15
@gaius-qi gaius-qi added the enhancement New feature or request label Jun 4, 2025
Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) June 4, 2025 09:16
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.79%. Comparing base (976fe3a) to head (74a0770).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   47.85%   47.79%   -0.06%     
==========================================
  Files          60       60              
  Lines       14195    14198       +3     
==========================================
- Hits         6793     6786       -7     
- Misses       7402     7412      +10     
Files with missing lines Coverage Δ
dragonfly-client/src/resource/piece.rs 64.26% <ø> (-0.59%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Liam-Zhao Liam-Zhao merged commit 8445806 into main Jun 4, 2025
9 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/remove-get-piece-span branch June 4, 2025 09:18
gaius-qi added a commit that referenced this pull request Jun 4, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jun 4, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants