Skip to content

feat: rename option log_to_stdout console for dfinit #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone May 29, 2025
@gaius-qi gaius-qi self-assigned this May 29, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 29, 2025 03:26
@gaius-qi gaius-qi added the enhancement New feature or request label May 29, 2025
Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 29, 2025 03:28
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.80%. Comparing base (7819702) to head (9c1fd43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client-init/src/bin/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
- Coverage   47.85%   47.80%   -0.05%     
==========================================
  Files          60       60              
  Lines       14195    14195              
==========================================
- Hits         6793     6786       -7     
- Misses       7402     7409       +7     
Files with missing lines Coverage Δ
dragonfly-client-init/src/bin/main.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Liam-Zhao Liam-Zhao merged commit 44d58fe into main May 29, 2025
9 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/console branch May 29, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants