feat(tracing): align resource attributes with OpenTelemetry semantic conventions #1164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
#[instrument(skip_all)]
attribute from various methods across multiple modules in thedragonfly-client-backend
anddragonfly-client-storage
codebase. These changes simplify the code by eliminating unnecessary tracing instrumentation, which was previously used to skip logging the function arguments.Removal of
#[instrument(skip_all)]
Attributes:Backend Modules:
dragonfly-client-backend/src/hdfs.rs
: Removed#[instrument(skip_all)]
from methods in theHdfs
struct, includingnew
,operator
, andscheme
. [1] [2]dragonfly-client-backend/src/http.rs
: Removed#[instrument(skip_all)]
from methods in theHTTP
struct, such asnew
,client
, andscheme
. [1] [2] [3]dragonfly-client-backend/src/lib.rs
: Removed#[instrument(skip_all)]
from methods in theBackendFactory
struct, includingnew
,supported_download_directory
, andbuild
. [1] [2] [3]Object Storage Module:
dragonfly-client-backend/src/object_storage.rs
: Removed#[instrument(skip_all)]
from methods in theObjectStorage
struct, such asnew
,operator
, and various storage operator initializations (e.g.,s3_operator
,gcs_operator
). [1] [2] [3] [4] [5] [6] [7] [8]Storage Modules:
dragonfly-client-storage/src/content.rs
: Removed#[instrument(skip_all)]
from methods in theContent
struct, includingnew
,available_space
,total_space
,has_enough_space
, and task-related operations (e.g.,create_task
,delete_task
). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]dragonfly-client-storage/src/lib.rs
: Removed#[instrument(skip_all)]
from methods in theStorage
struct, such asnew
,total_space
,available_space
,has_enough_space
, and metadata-related operations (e.g.,get_piece
,get_pieces
). [1] [2] [3] [4] [5] [6]General Cleanup:
dragonfly-client-backend/src/lib.rs
: Removed the unusedinstrument
import from thetracing
crate.These changes reduce the overhead of unnecessary instrumentation and streamline the codebase, making it easier to maintain and understand.
Related Issue
Motivation and Context
Screenshots (if appropriate)