Skip to content

feat(tracing): align resource attributes with OpenTelemetry semantic conventions #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request removes the #[instrument(skip_all)] attribute from various methods across multiple modules in the dragonfly-client-backend and dragonfly-client-storage codebase. These changes simplify the code by eliminating unnecessary tracing instrumentation, which was previously used to skip logging the function arguments.

Removal of #[instrument(skip_all)] Attributes:

Backend Modules:

Object Storage Module:

Storage Modules:

General Cleanup:

These changes reduce the overhead of unnecessary instrumentation and streamline the codebase, making it easier to maintain and understand.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.3.0 milestone May 28, 2025
@gaius-qi gaius-qi self-assigned this May 28, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 28, 2025 14:42
@gaius-qi gaius-qi added the enhancement New feature or request label May 28, 2025
@github-actions github-actions bot requested review from CormickKneey and yxxhero May 28, 2025 14:43
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 164 lines in your changes missing coverage. Please review.

Project coverage is 47.80%. Comparing base (3959bb9) to head (3bf9d6c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 56 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_download.rs 0.00% 40 Missing ⚠️
dragonfly-client/src/tracing/mod.rs 0.00% 26 Missing ⚠️
dragonfly-client/src/grpc/interceptor.rs 0.00% 20 Missing ⚠️
dragonfly-client/src/grpc/scheduler.rs 0.00% 12 Missing ⚠️
dragonfly-client/src/grpc/health.rs 0.00% 2 Missing ⚠️
dragonfly-client-init/src/bin/main.rs 0.00% 1 Missing ⚠️
dragonfly-client/src/bin/dfcache/export.rs 0.00% 1 Missing ⚠️
dragonfly-client/src/bin/dfcache/import.rs 0.00% 1 Missing ⚠️
dragonfly-client/src/bin/dfcache/stat.rs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
- Coverage   49.33%   47.80%   -1.54%     
==========================================
  Files          58       60       +2     
  Lines       12114    14195    +2081     
==========================================
+ Hits         5977     6786     +809     
- Misses       6137     7409    +1272     
Files with missing lines Coverage Δ
dragonfly-client-backend/src/hdfs.rs 26.66% <ø> (+13.78%) ⬆️
dragonfly-client-backend/src/http.rs 98.31% <ø> (+0.34%) ⬆️
dragonfly-client-backend/src/lib.rs 95.47% <ø> (-2.07%) ⬇️
dragonfly-client-backend/src/object_storage.rs 87.78% <ø> (+3.16%) ⬆️
dragonfly-client-storage/src/content.rs 80.35% <ø> (-3.31%) ⬇️
dragonfly-client-storage/src/lib.rs 19.48% <ø> (+10.90%) ⬆️
dragonfly-client-storage/src/metadata.rs 64.19% <ø> (-0.47%) ⬇️
...onfly-client-storage/src/storage_engine/rocksdb.rs 97.38% <ø> (+1.50%) ⬆️
dragonfly-client-util/src/http/basic_auth.rs 97.32% <ø> (+0.15%) ⬆️
dragonfly-client-util/src/http/mod.rs 99.01% <ø> (+0.80%) ⬆️
... and 27 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…conventions

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 28, 2025 15:16
@Liam-Zhao Liam-Zhao merged commit 7819702 into main May 28, 2025
15 of 16 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/tracing branch May 28, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants