Skip to content

feat: rename --log-to-stdout to --console #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

feat: rename --log-to-stdout to --console #1163

merged 1 commit into from
May 27, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces changes to improve logging configuration and build processes across multiple components of the Dragonfly project. The key updates include replacing the --log-to-stdout option with --console for logging, updating related documentation, and enhancing build commands for better verbosity.

Logging Configuration Updates:

Build Process Enhancements:

  • ci/Dockerfile, ci/Dockerfile.debug, ci/Dockerfile.dfinit: Updated cargo build commands to include the --verbose flag for improved build output during image creation. [1] [2] [3]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone May 27, 2025
@gaius-qi gaius-qi self-assigned this May 27, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 27, 2025 07:27
@gaius-qi gaius-qi added the enhancement New feature or request label May 27, 2025
Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 27, 2025 07:27
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.39%. Comparing base (7b1cdbe) to head (78e4e31).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/bin/dfcache/export.rs 0.00% 2 Missing ⚠️
dragonfly-client/src/bin/dfcache/import.rs 0.00% 2 Missing ⚠️
dragonfly-client/src/bin/dfcache/stat.rs 0.00% 2 Missing ⚠️
dragonfly-client/src/bin/dfdaemon/main.rs 0.00% 2 Missing ⚠️
dragonfly-client/src/bin/dfget/main.rs 0.00% 2 Missing ⚠️
dragonfly-client/src/tracing/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   49.39%   49.39%           
=======================================
  Files          58       58           
  Lines       12114    12114           
=======================================
  Hits         5984     5984           
  Misses       6130     6130           
Files with missing lines Coverage Δ
dragonfly-client/src/bin/dfcache/export.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/import.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfcache/stat.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfdaemon/main.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfget/main.rs 25.09% <0.00%> (ø)
dragonfly-client/src/tracing/mod.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Liam-Zhao Liam-Zhao merged commit 3959bb9 into main May 27, 2025
8 of 9 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/console branch May 27, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants