Skip to content

feat: add hardlink when task is downloaded #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

feat: add hardlink when task is downloaded #1151

merged 1 commit into from
May 19, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes updates to the Cargo.toml file and introduces new functionality in the dragonfly-client project. The changes primarily involve version updates for dependencies and a new feature for handling hard links during task processing.

Dependency Updates:

  • Updated the workspace version from 0.2.29 to 0.2.30 in Cargo.toml. This includes all related dependencies such as dragonfly-client, dragonfly-client-core, dragonfly-client-config, and others. [1] [2]

New Feature:

  • Added logic in dragonfly-client/src/resource/task.rs to handle hard link creation for task files. The behavior depends on the force_hard_link setting:
    • If force_hard_link is true, an error is returned immediately if hard link creation fails.
    • If force_hard_link is false, it falls back to copying the file if hard link creation fails.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.3.0 milestone May 19, 2025
@gaius-qi gaius-qi self-assigned this May 19, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 19, 2025 10:15
@gaius-qi gaius-qi added the enhancement New feature or request label May 19, 2025
@github-actions github-actions bot requested review from chlins and yxxhero May 19, 2025 10:15
Liam-Zhao
Liam-Zhao previously approved these changes May 19, 2025
Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chlins
chlins previously approved these changes May 19, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) May 19, 2025 10:17
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi dismissed stale reviews from chlins and Liam-Zhao via 2917d24 May 19, 2025 10:24
@gaius-qi gaius-qi force-pushed the feature/hardlink branch from b90873f to 2917d24 Compare May 19, 2025 10:24
@gaius-qi gaius-qi requested a review from a team as a code owner May 19, 2025 10:24
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi disabled auto-merge May 19, 2025 10:33
@gaius-qi gaius-qi merged commit 3811569 into main May 19, 2025
7 checks passed
@gaius-qi gaius-qi deleted the feature/hardlink branch May 19, 2025 10:34
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.45%. Comparing base (44362c6) to head (2917d24).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1151   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files          58       58           
  Lines       12085    12085           
=======================================
  Hits         5977     5977           
  Misses       6108     6108           
Files with missing lines Coverage Δ
dragonfly-client/src/resource/task.rs 9.29% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants