Skip to content

feat: increase GRPC REQUEST_TIMEOUT to 15 seconds and add comment #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes updates to the Cargo.toml file to bump the version of multiple dependencies and the package itself, as well as a change to the REQUEST_TIMEOUT constant in the grpc module to extend the timeout duration and provide additional documentation.

Dependency and version updates:

  • Updated the package version in Cargo.toml from 0.2.28 to 0.2.29.
  • Updated the versions of several workspace dependencies (dragonfly-client, dragonfly-client-core, dragonfly-client-config, etc.) in Cargo.toml from 0.2.28 to 0.2.29.

Timeout configuration changes:

  • Increased the REQUEST_TIMEOUT constant in dragonfly-client/src/grpc/mod.rs from 5 seconds to 15 seconds and added detailed documentation explaining its purpose and relation to scheduler configuration.

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.3.0 milestone May 19, 2025
@gaius-qi gaius-qi self-assigned this May 19, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label May 19, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 19, 2025 03:46
@github-actions github-actions bot requested a review from xujihui1985 May 19, 2025 03:46
Copy link
Contributor

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 19, 2025 03:47
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.45%. Comparing base (604a945) to head (9b6c127).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
- Coverage   49.51%   49.45%   -0.06%     
==========================================
  Files          58       58              
  Lines       12085    12085              
==========================================
- Hits         5984     5977       -7     
- Misses       6101     6108       +7     
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/mod.rs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gaius-qi gaius-qi disabled auto-merge May 19, 2025 03:49
@Liam-Zhao Liam-Zhao merged commit 44362c6 into main May 19, 2025
8 of 10 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/timeout branch May 19, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants