feat: add task type to ID generation for Standard and PersistentCache tasks #1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
IDGenerator
indragonfly-client-util
to include theTaskType
in its hashing logic and modifies the associated test cases to reflect the new behavior. These changes ensure that task IDs are now uniquely influenced by their task type, improving the specificity of the generated IDs.Core functionality updates:
TaskType::Standard
andTaskType::PersistentCache
to the hashing logic in theIDGenerator
implementation, ensuring task IDs are differentiated by their task type. [1] [2]Test updates:
mod tests
to align with the new hashing logic that incorporatesTaskType
. This affects multiple test cases, ensuring they reflect the updated ID generation behavior:application
andfiltered_query_params
. [1] [2] [3] [4] [5] [6]tag
andapplication
. [1] [2] [3] [4]Related Issue
Motivation and Context
Screenshots (if appropriate)