feat(dragonfly-client): replace inspect_err with unwrap_or_else for error handling in piece download requests #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror handling in piece download requests Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
force-pushed
the
feature/remove-error
branch
from
62cf1f7 to
0fc1d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the use of
.inspect_errwith.unwrap_or_elsein multiple locations across thePersistentCacheTaskandTaskimplementations. This change ensures that errors are handled explicitly without propagating them further, improving error handling and making the code more robust.Changes in
PersistentCacheTask(dragonfly-client/src/resource/persistent_cache_task.rs):.inspect_errwith.unwrap_or_elseto handle errors when sendingDownloadPieceFinishedRequestandDownloadPieceFinishedResponse, ensuring errors are logged and theinterruptflag is set appropriately. [1] [2] [3]Changes in
Task(dragonfly-client/src/resource/task.rs):.inspect_errto.unwrap_or_elsefor error handling when sendingDownloadPieceFinishedRequest,DownloadPieceFinishedResponse, andDownloadPieceBackToSourceFinishedRequest. This ensures errors are logged and handled explicitly without propagating them further. [1] [2] [3] [4] [5] [6]Related Issue
Motivation and Context
Screenshots (if appropriate)