Skip to content

feat(dragonfly-client): add logs for finished piece from local #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes changes to optimize download behavior and improve logging in the dragonfly-client project. The most important changes involve reducing the default concurrent piece download count and adding logging for completed pieces.

Download behavior optimization:

Logging improvements:

  • dragonfly-client/src/resource/piece.rs: Added info log statements to indicate when a piece or a persistent cache piece is finished and retrieved locally. This change appears in three locations within the impl Piece block. [1] [2] [3]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone May 12, 2025
@gaius-qi gaius-qi self-assigned this May 12, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 12, 2025 15:44
@gaius-qi gaius-qi added the enhancement New feature or request label May 12, 2025
@gaius-qi gaius-qi merged commit c11f533 into main May 12, 2025
9 checks passed
@gaius-qi gaius-qi deleted the feature/log branch May 12, 2025 15:47
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (5bc3a0a) to head (828ccb9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1147   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files          58       58           
  Lines       12075    12075           
=======================================
  Hits         5977     5977           
  Misses       6098     6098           
Files with missing lines Coverage Δ
dragonfly-client-config/src/dfdaemon.rs 92.10% <100.00%> (ø)
dragonfly-client/src/resource/piece.rs 60.71% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant