-
Notifications
You must be signed in to change notification settings - Fork 137
Doc: feature band source building #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- PSB artifacts: Source-built previous N.0.2xx release | ||
- SDK: Source-built previous N.0.2xx release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what we agreed on for 3xx? You would never use 3xx SDK or artifacts to build the next version? You would always use 2xx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice write-up. There is a lot of good content here.
|
||
Enhanced SDK tooling that ships with Visual Studio updates: | ||
|
||
- **Content**: Contains only SDK tooling differences from 1xx band (subset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of including "differences" here. It can be interpreted that source deltas are the only thing contained. The entire SDK tooling is included not just the differences.
|
||
### 3xx Band Build Requirements | ||
|
||
- **Bootstrap (any version)**: Two-stage process using Microsoft source-built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing IMO because you really don't bootstrap 3xx at all. You are always using 2xx artifacts/sdk to build 3xx. The bootstrap here really applies to 2xx.
|
||
- **Bootstrap (any version)**: Two-stage process using Microsoft source-built | ||
2xx artifacts + Microsoft 2xx SDK + prep script | ||
- **Initial Release (N.0.200)**: Latest source-built 1xx artifacts + Latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by latest? Latest released or latest as in tip? The document should be consistent in the terminology used - e.g. current/previous
- Shared component artifacts: Source-built current N.0.1xx release | ||
- PSB artifacts: Source-built previous N.0.2xx release | ||
- SDK: Source-built previous N.0.2xx release | ||
- **Bootstrap (N.0.300)**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the value in bootstrapping 3xx as it never produces a true source built product. To me you would bootstrap 2xx and then do a normal 3xx build.
# Final source-built outputs available in artifacts/x64/Release/ | ||
``` | ||
|
||
```mermaid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have a more consistent naming of the Build Process inputs that map more closely to the build script? e.g. sdk/packages/shared-components or with-sdk/with-packages/with-shared-components?
# Final source-built outputs available in artifacts/x64/Release/ | ||
``` | ||
|
||
```mermaid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to include 2xx in the Microsoft-built SDK and artifacts nodes.
- PSB artifacts: Source-built previous N.0.2xx release | ||
- SDK: Source-built previous N.0.2xx release | ||
|
||
### Scenario 1: 1xx Band Bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this doc as being a useful reference at times. Because of that I think have a table of contents would be useful mainly for these scenarios.
- Include shared runtime and foundational components that all feature bands | ||
depend on | ||
|
||
## Feature Band Characteristics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually this should reference SDK documentation the feature bands which isn't finalized yet.
- PSB artifacts: Source-built previous N.0.2xx release | ||
- SDK: Source-built previous N.0.2xx release | ||
|
||
### Scenario 1: 1xx Band Bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see the 'Input Artifacts Summary' as being redundant with these scenarios. IMO the summary should be removed. When I read it I wanted to see this information along side the contents in the summary.
- PSB artifacts: Source-built previous N.0.2xx release | ||
- SDK: Source-built previous N.0.2xx release | ||
|
||
### Scenario 1: 1xx Band Bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO scenario x
in the headings doesn't add value. The descriptive name is what is useful.
This document provides guidance for Linux distribution maintainers on source building .NET SDK feature band branches of the VMR. It covers bootstrapping and ongoing servicing workflows when building multiple SDK feature bands.
Fixes #5354