Use SdkResolver APIs for reporting environment variables #49866
+73
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations, report all VS-env validation errors in one batch
baronfel
commented
Jul 19, 2025
Comment on lines
-136
to
+145
| <MicrosoftBclAsyncInterfacesToolsetPackageVersion>8.0.0</MicrosoftBclAsyncInterfacesToolsetPackageVersion> | ||
| <MicrosoftBclAsyncInterfacesToolsetPackageVersion>9.0.0</MicrosoftBclAsyncInterfacesToolsetPackageVersion> | ||
| <MicrosoftDeploymentDotNetReleasesToolsetPackageVersion>2.0.0-preview.1.24427.4</MicrosoftDeploymentDotNetReleasesToolsetPackageVersion> | ||
| <SystemBuffersToolsetPackageVersion>4.5.1</SystemBuffersToolsetPackageVersion> | ||
| <SystemCollectionsImmutableToolsetPackageVersion>8.0.0</SystemCollectionsImmutableToolsetPackageVersion> | ||
| <SystemCollectionsImmutableToolsetPackageVersion>9.0.0</SystemCollectionsImmutableToolsetPackageVersion> | ||
| <SystemMemoryToolsetPackageVersion>4.5.5</SystemMemoryToolsetPackageVersion> | ||
| <SystemReflectionMetadataLoadContextToolsetPackageVersion>8.0.0</SystemReflectionMetadataLoadContextToolsetPackageVersion> | ||
| <SystemReflectionMetadataToolsetPackageVersion>8.0.0</SystemReflectionMetadataToolsetPackageVersion> | ||
| <SystemTextJsonToolsetPackageVersion>8.0.5</SystemTextJsonToolsetPackageVersion> | ||
| <SystemReflectionMetadataLoadContextToolsetPackageVersion>9.0.0</SystemReflectionMetadataLoadContextToolsetPackageVersion> | ||
| <SystemReflectionMetadataToolsetPackageVersion>9.0.0</SystemReflectionMetadataToolsetPackageVersion> | ||
| <SystemTextJsonToolsetPackageVersion>9.0.0</SystemTextJsonToolsetPackageVersion> | ||
| <SystemThreadingTasksExtensionsToolsetPackageVersion>4.5.4</SystemThreadingTasksExtensionsToolsetPackageVersion> | ||
| <SystemResourcesExtensionsToolsetPackageVersion>8.0.0</SystemResourcesExtensionsToolsetPackageVersion> | ||
| <SystemResourcesExtensionsToolsetPackageVersion>9.0.0</SystemResourcesExtensionsToolsetPackageVersion> |
There was a problem hiding this comment.
All of this is the scary stuff @rainersigwald @YuliiaKovalova @marcpopMSFT @jaredpar
How do we usually navigate/negotiate bumps to these shared dependencies between MSBuild/Roslyn/SDK/VS?
baronfel
changed the base branch from
darc-main-7628065e-94f2-4f11-a6d5-3ab587167c53
to
main
|
Where are the actual changes? This seems to mostly be SC.L related. |
This was referenced Jul 19, 2025
Open
baronfel
changed the base branch from
main
to
darc-main-7628065e-94f2-4f11-a6d5-3ab587167c53
…e-real-sdkresolver-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the MSBuild API changes from #49740. This PR is targeting
mainonly because our pipelines aren't set up to allow PR runs for branches/PRs that are themselves branched off off of darc-codeflow branches.This uses the proper APIs for reporting env variables, but because it requires a newer version of the MSBuild APIs and those APIs have brought increased dependency bumps we probably need to take a deeper look at the coordination involved here.