Don't put testing global.json in artifacts dir directly #49819
+44
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move testing into a subfolder under artifacts/tmp Prevents interference between the testing global.json with Arcade's signing logic
There was a problem hiding this comment.
Pull Request Overview
This PR moves testing-related files from being placed directly in the artifacts directory to a dedicated subfolder under artifacts/tmp/testing/. This change prevents interference between the testing global.json and Arcade's signing logic by isolating test artifacts from build artifacts.
Key changes:
- Introduces a new
TestLayoutDirproperty pointing toartifacts/tmp/testing/ - Updates all MSBuild targets to use
TestLayoutDirinstead ofArtifactsTmpDirfor test-related file operations - Modifies global.json generation to create files in both the artifacts bin directory and the new test layout directory
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Introduces the new TestLayoutDir property |
| src/Layout/redist/targets/GenerateTestingGlobalJson.targets | Updates global.json generation to target both artifacts bin and test layout directories |
| test/*.csproj and *.targets | Updates all test project files to use TestLayoutDir instead of ArtifactsTmpDir |
| src/Containers/*.csproj | Updates container-related projects to copy test files to the new test layout directory |
| template_feed/*.csproj | Updates template projects to output to the new test layout directory |
|
I expect this to break lots of tests - I think it had to go in that directory so that test usages would all work. WAIT you're a genius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move testing into a subfolder under artifacts/tmp
Prevents interference between the testing global.json with Arcade's signing logic
Fixes dotnet/dotnet#1486