Skip to content

Remove env var workaround that causes dotnet to use MSBuild out-of-proc #49750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove env var workaround that causes dotnet to use MSBuild out-of-proc #49750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,6 @@ public void EnvironmentVariable(string name, string value)
{
_msbuildRequiredEnvironmentVariables.Add(name, value);
Copy link
Preview

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the fallback for empty or null-character environment values changes behavior for those inputs; please add or update tests to cover setting environment variables with an empty string or '\0' to ensure correct in-proc behavior on .NET 8+.

Copilot uses AI. Check for mistakes.

}

if (value == string.Empty || value == "\0")
{
// Unlike ProcessStartInfo.EnvironmentVariables, Environment.SetEnvironmentVariable can't set a variable
// to an empty value, so we just fall back to calling MSBuild out-of-proc if we encounter this case.
// https://github.com/dotnet/runtime/issues/50554
InitializeForOutOfProcForwarding();

// Disable MSBUILDUSESERVER if any env vars are null as those are not properly transferred to build nodes
_msbuildRequiredEnvironmentVariables["MSBUILDUSESERVER"] = "0";
}
}

public int Execute()
Expand Down