Skip to content

Re-enable DotNet.Watcher.Tests #49642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Re-enable DotNet.Watcher.Tests #49642

wants to merge 4 commits into from

Conversation

SimonZhao888
Copy link
Member

@build-analysis build-analysis bot mentioned this pull request Jul 3, 2025
Open
@SimonZhao888
Copy link
Member Author

@tmat, are we allowed to use Task.Delay() method in test case to enhance the stability of test case?

@tmat
Copy link
Member

tmat commented Jul 7, 2025

@SimonZhao888 Please, no task delays.

tmat
tmat requested changes Jul 7, 2025
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not appropriate way of fixing tests.

Simon Zhao (BEYONDSOFT CONSULTING INC) added 2 commits July 16, 2025 17:02
@build-analysis build-analysis bot mentioned this pull request Jul 16, 2025
Open
@SimonZhao888 SimonZhao888 marked this pull request as ready for review July 17, 2025 08:28
@SimonZhao888 SimonZhao888 requested a review from a team as a code owner July 17, 2025 08:28
@SimonZhao888 SimonZhao888 added the Area-Containers Related to dotnet SDK containers functionality label Jul 17, 2025
@build-analysis build-analysis bot mentioned this pull request Jul 17, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Area-Containers Related to dotnet SDK containers functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonZhao888 @tmat