Build & run tests for test templates via a pipeline to support CG #49147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces automated execution of test-template integration tests by extending the SDK build pipeline.
- Adds a new pipeline step to invoke a PowerShell script for test-template tests
- Provides
RunTestTemplateTests.ps1to run the dotnet-new integration tests in the dogfood environment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/sdk-build.yml | Inserts a powershell step to run RunTestTemplateTests.ps1 |
| build/RunTestTemplateTests.ps1 | Adds a script that locates and runs the dotnet-new integration tests |
Comments suppressed due to low confidence (2)
build/RunTestTemplateTests.ps1:15
- [nitpick] Consider renaming
$classNameFilterto something like$filterOptionor$filterArgto better reflect that it's thedotnet testfilter flag, not specifically a class-name filter.
$classNameFilter = "--filter"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…dotnet/sdk into dev/mabdullah/test-templates-cg
fhnaseer
approved these changes
May 28, 2025
mariam-abdulla
changed the title
Evangelink
approved these changes
May 28, 2025
| @@ -4,7 +4,6 @@ VisualStudioVersion = 17.1.31903.286 | |||
| MinimumVisualStudioVersion = 10.0.40219.1 | |||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{50A89C27-BA35-44B2-AC57-E54551791C64}" | |||
| ProjectSection(SolutionItems) = preProject | |||
| eng\cgmanifest.json = eng\cgmanifest.json | |||
There was a problem hiding this comment.
Was it requested to drop the manifest?
There was a problem hiding this comment.
Building and running those test projects is the other way to report our used packages to CG.
| $ErrorActionPreference = 'Stop' | ||
| $RepoRoot = Resolve-Path (Join-Path $PSScriptRoot '..') | ||
| $classNameFilter = "--filter" | ||
| $filterValue = "FullyQualifiedName~Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewTestTemplatesTests" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new PowerShell script to run test template tests in the dogfood environment and integrates it into the SDK build pipeline. The key changes include the addition of the script and its execution step in the pipeline configuration.
Additions to test execution:
build/RunTestTemplateTests.ps1: Added a new PowerShell script to run theMicrosoft.TestTemplates.Acceptance.Tests.dllin the dogfood environment. The script includes functionality to locate the test DLL, verify its existence, and execute it using thedogfood.ps1script. It also handles error reporting and exit codes.Pipeline integration:
eng/pipelines/templates/jobs/sdk-build.yml: Integrated the newRunTestTemplateTests.ps1script into the SDK build pipeline by adding a PowerShell step to execute the script. This step is labeled "🟣 Run Test Templates Tests" in the pipeline.