Skip to content

Skip CanFilterAuthor_WithoutName test to unblock main #49124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Skip CanFilterAuthor_WithoutName test to unblock main #49124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f2807a
Skip CanFilterAuthor_WithoutName test to unblock main
v-wuzhai May 23, 2025
a05a8c3
Suppress xUnit1004 rule for skipped test
v-wuzhai May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
Assert.True(AtLeastOneRowIsNotEmpty(tableOutput, "Downloads"), "'Downloads' column contains empty values");
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")]

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build AoT: macOS (x64))

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (arm64))

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: macOS (x64))

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TestBuild: linux (x64))

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: linux (x64))

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [fedora39])

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build TemplateEngine: macOS (x64))

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [ubuntu2204DebPkg])

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [alpine319WithNode])

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [centosStream9])

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)

Check failure on line 223 in test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs

View check run for this annotation

Azure Pipelines / dotnet-sdk-public-ci (Build ContainerBased: linux (x64) [debian12Amd64])

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs#L223 

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs(223,17): error xUnit1004: (NETCORE_ENGINEERING_TELEMETRY=Build) Test methods should not be skipped. Remove the Skip property to start running the test again. (https://xunit.net/xunit.analyzers/rules/xUnit1004)
Copy link
Preview

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a brief skip reason alongside the URL, e.g., Skip = "Skipped due to issue #49123: incorrect author filtering" to clarify why the test is disabled.

Suggested change
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123: Skipped due to issue #49123: incorrect author filtering")]

Copilot uses AI. Check for mistakes.

[InlineData("--search --columns author --author micro")]
[InlineData("search --columns author --author micro")]
public void CanFilterAuthor_WithoutName(string testCase)
Expand Down
Loading