Fix Microsoft.IO.Redist versions #48819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fted up to a supported version Upgrade the minimum msbuild which had a 6.0.0 reference
joeloff
reviewed
May 6, 2025
joeloff
approved these changes
May 6, 2025
…MSBuild is not built into the dependency graph
ericstj
reviewed
May 6, 2025
| @@ -61,8 +61,8 @@ | |||
| </ItemDefinitionGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="Runtime" /> | |||
| <PackageReference Include="Microsoft.Build.Utilities.Core" ExcludeAssets="Runtime" /> | |||
| <PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="Runtime" IncludeAssets="Compile" /> | |||
There was a problem hiding this comment.
You can remove ExcludeAssets="Runtime" - it's trying to do the same thing, but doesn't exclude everything that might be considered a non-development asset. That's not causing an issue here, but better to standardize on IncludeAssets
|
I think you should adjust this condition, and below: Line 135 in a63310c Test projects should use the latest, not minimum. That way your tests (which deploy MSBuild) can run against the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Microsoft.IO.Redist to Directory.packages.props to ensure it's lifted up to a supported version
Upgrade the minimum msbuild which had a 6.0.0 reference