Implement getAsyncInfo in ILCompiler #120859
Open
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
requested review from
VSadov,
agocke,
Copilot,
eduardo-vp and
jakobbotsch
There was a problem hiding this comment.
Pull Request Overview
This PR implements the getAsyncInfo callback in the ILCompiler's JIT interface to support async method compilation in ReadyToRun scenarios. The implementation aligns with CoreCLR's definition by expanding the CORINFO_ASYNC_INFO structure and providing concrete field and method handle lookups.
Key Changes:
- Extended
CORINFO_ASYNC_INFOstructure with additional fields for async state management - Implemented the
getAsyncInfomethod to populate async continuation and context management handles - Added support for execution context capture/restore operations in async workflows
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/coreclr/tools/Common/JitInterface/CorInfoTypes.cs |
Extended CORINFO_ASYNC_INFO structure with new fields for Resume, State, Flags, execution context methods, and continuation context handling |
src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs |
Implemented getAsyncInfo method to populate async info structure with handles for Continuation class fields and AsyncHelpers methods |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This will change a bit after #120411 cc @jakobbotsch |
jkotas
reviewed
Oct 18, 2025
jkotas
approved these changes
Oct 18, 2025
|
Yes, the shape of the info will change with "flat continuations". |
VSadov
approved these changes
Oct 18, 2025
| private void getAsyncInfo(ref CORINFO_ASYNC_INFO pAsyncInfoOut) | ||
| { | ||
| throw new NotImplementedException(); | ||
| DefType continuation = MethodBeingCompiled.Context.SystemModule.GetType("System.Runtime.CompilerServices"u8, "Continuation"u8); |
There was a problem hiding this comment.
(Same comment for all GetType uses below.)
GetTypecan return null and we'd nullref,GetKnownTypewon't return null and will print a better error message if e.g. CoreLib is mismatched.- Nit: context is available through a non-virtual path on
_compilation.TypeSystemContext.
Suggested change
| DefType continuation = MethodBeingCompiled.Context.SystemModule.GetType("System.Runtime.CompilerServices"u8, "Continuation"u8); | |
| DefType continuation = _compilation.TypeSystemContext.SystemModule.GetKnownType("System.Runtime.CompilerServices"u8, "Continuation"u8); |
| pAsyncInfoOut.continuationsNeedMethodHandle = false; | ||
| DefType asyncHelpers = MethodBeingCompiled.Context.SystemModule.GetType("System.Runtime.CompilerServices"u8, "AsyncHelpers"u8); | ||
| DefType executionContext = MethodBeingCompiled.Context.SystemModule.GetType("System.Threading"u8, "ExecutionContext"u8); | ||
| DefType @void = MethodBeingCompiled.Context.GetWellKnownType(WellKnownType.Void); |
| DefType continuation = MethodBeingCompiled.Context.SystemModule.GetType("System.Runtime.CompilerServices"u8, "Continuation"u8); | ||
| pAsyncInfoOut.continuationClsHnd = ObjectToHandle(continuation); | ||
| // 'Next' field | ||
| pAsyncInfoOut.continuationNextFldHnd = ObjectToHandle(continuation.GetField("Next"u8)); |
There was a problem hiding this comment.
Also a better exception if corelib is mismatched (same comment for other GetField below).
Suggested change
| pAsyncInfoOut.continuationNextFldHnd = ObjectToHandle(continuation.GetField("Next"u8)); | |
| pAsyncInfoOut.continuationNextFldHnd = ObjectToHandle(continuation.GetKnownField("Next"u8)); |
| DefType executionContext = MethodBeingCompiled.Context.SystemModule.GetType("System.Threading"u8, "ExecutionContext"u8); | ||
| DefType @void = MethodBeingCompiled.Context.GetWellKnownType(WellKnownType.Void); | ||
| // Method handle for AsyncHelpers.CaptureExecutionContext | ||
| pAsyncInfoOut.captureExecutionContextMethHnd = ObjectToHandle(asyncHelpers.GetMethod("CaptureExecutionContext"u8, null)); |
There was a problem hiding this comment.
Suggested change
| pAsyncInfoOut.captureExecutionContextMethHnd = ObjectToHandle(asyncHelpers.GetMethod("CaptureExecutionContext"u8, null)); | |
| pAsyncInfoOut.captureExecutionContextMethHnd = ObjectToHandle(asyncHelpers.GetKnownMethod("CaptureExecutionContext"u8, null)); |
|
I merged #120411 so as pointed out above the shape of |
jakobbotsch
requested changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the definition of CORINFO_ASYNC_INFO to match CoreCLRs definition, and adds an implementation for the
getAsyncInfojit callback in ReadyToRun.