Skip to content

Conversation

max-charlamb
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 17:49
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cDAC (Contract-based Debug Access Component) transport package build configuration to publish packages for both the target runtime and the SDK runtime identifier. The changes modify how the mscordaccore_universal library files are included in the package, supporting both native runtime-specific builds and managed any-runtime builds.

Key Changes:

  • Modified package build logic to create two package variants: one for the target runtime and one for the SDK runtime
  • Updated file inclusion patterns to differentiate between native runtime-specific files and managed any-runtime files
  • Simplified the DotNetCdacBinDir path definition to support the new multi-variant packaging approach

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/installer/pkg/projects/cdac-packages.proj Adds logic to build the transport package twice: once for $(TargetRid) and once for $(NETCoreSdkRuntimeIdentifier)
src/installer/pkg/projects/Microsoft.DotNet.Cdac.Transport/Microsoft.DotNet.Cdac.Transport.pkgproj Adds conditional file inclusion logic to package native files for target runtime and managed files for SDK runtime
Directory.Build.props Simplifies DotNetCdacBinDir path by removing the /$(PortableTargetRid)/publish suffix

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Oct 17, 2025

What's the intended set of files for the managed package (as compared to the rid-based ones which is the published DAC)?

(Just trying to figure out if there's a better/different recommended way to do this as pkgproj is funky).

@hoyosjs
Copy link
Member

hoyosjs commented Oct 17, 2025

Ilonly assets.

@max-charlamb max-charlamb added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 17, 2025
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants