Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 16, 2025

This PR adds two YAML files (eng/pipelines/helix-platforms-latest.yml and eng/pipelines/helix-platforms-oldest.yml) to centralize Helix platform queue name mappings. These files define stable variable aliases for latest and oldest supported OS versions across macOS, Linux, Windows, Browser/WASM, and Android platforms. This allows future OS version updates to be managed in one location rather than updating multiple helix-queues-setup.yml templates throughout the codebase.

The current OS choices are arbitrary -- if #120337 is approved, I will update the baselines then update our actual Helix setup to match the definitions.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 16, 2025
…tions

Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Add YAML file for Helix platform alias mappings Add centralized Helix platform alias definitions file Oct 16, 2025
@Copilot Copilot AI requested a review from agocke October 16, 2025 20:48
Copilot finished work on behalf of agocke October 16, 2025 20:48
Updated Helix platform definitions to include latest supported versions for macOS, Linux, Windows, and Android platforms. Added internal variable mappings for various platforms.
@agocke
Copy link
Member

agocke commented Oct 16, 2025

@copilot Please also add a file for oldest supported versions

Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 16, 2025

@copilot Please also add a file for oldest supported versions

Added eng/pipelines/helix-platforms-oldest.yml with oldest/baseline supported platform versions (commit 1c71c94). The file mirrors the structure of the latest file and includes definitions for macOS, Linux, Windows, Browser/WASM, and Android platforms.

@Copilot Copilot AI changed the title Add centralized Helix platform alias definitions file Add centralized Helix platform alias definitions files Oct 16, 2025
Copilot finished work on behalf of agocke October 16, 2025 22:35
@agocke
Copy link
Member

agocke commented Oct 16, 2025

@copilot Please update the description

Copy link
Contributor Author

Copilot AI commented Oct 16, 2025

@copilot Please update the description

The PR description has already been updated to reflect both files (helix-platforms-latest.yml and helix-platforms-oldest.yml). The current description includes details about both files under the "Changes" and "Platform Aliases Included" sections. Is there a specific aspect of the description you'd like me to modify?

Copilot finished work on behalf of agocke October 16, 2025 23:06
@agocke
Copy link
Member

agocke commented Oct 16, 2025

@copilot please reduce the PR description to a short paragraph

Copy link
Contributor Author

Copilot AI commented Oct 16, 2025

@copilot please reduce the PR description to a short paragraph

I don't have the ability to directly edit the PR description on GitHub. However, here's a suggested short paragraph you can use:

"This PR adds two YAML files (eng/pipelines/helix-platforms-latest.yml and eng/pipelines/helix-platforms-oldest.yml) to centralize Helix platform queue name mappings. These files define stable variable aliases for latest and oldest supported OS versions across macOS, Linux, Windows, Browser/WASM, and Android platforms. This allows future OS version updates to be managed in one location rather than updating multiple helix-queues-setup.yml templates throughout the codebase."

You'll need to manually update the PR description with this or a similar condensed version.

Copilot finished work on behalf of agocke October 16, 2025 23:35
@agocke agocke marked this pull request as ready for review October 17, 2025 01:40
@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 01:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces centralized Helix platform alias definitions by adding two YAML configuration files that define stable variable aliases for latest and oldest supported OS versions across multiple platforms. This centralizes version-specific Helix queue names that were previously duplicated across multiple templates, enabling future OS version updates to be managed from a single location.

  • Creates comprehensive platform mappings for macOS, Linux, Windows, Browser/WASM, and Android
  • Separates latest and oldest supported versions into dedicated files for clear version management
  • Provides both public (.Open) and internal queue variants for each platform

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
eng/pipelines/helix-platforms-latest.yml Defines latest supported platform versions with comprehensive coverage for all major OS families and architectures
eng/pipelines/helix-platforms-oldest.yml Defines oldest/baseline supported platform versions for backward compatibility testing

Comment on lines +69 to +73
value: (Fedora.42.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-42-helix-amd64

# Latest openSUSE x64 - 15.6
- name: helix_linux_x64_opensuse_latest
value: (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization in 'open' - should be 'Open' to match other queue definitions.

Suggested change
value: (Fedora.42.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-42-helix-amd64
# Latest openSUSE x64 - 15.6
- name: helix_linux_x64_opensuse_latest
value: (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64
value: (Fedora.42.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-42-helix-amd64
# Latest openSUSE x64 - 15.6
- name: helix_linux_x64_opensuse_latest
value: (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64

Copilot uses AI. Check for mistakes.


# Latest openSUSE x64 - 15.6
- name: helix_linux_x64_opensuse_latest
value: (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization in 'open' - should be 'Open' to match other queue definitions.

Suggested change
value: (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64
value: (openSUSE.15.6.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.6-helix-amd64

Copilot uses AI. Check for mistakes.


# Oldest supported Fedora x64 - 40
- name: helix_linux_x64_fedora_oldest
value: (Fedora.40.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-40-helix-amd64
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization in 'open' - should be 'Open' to match other queue definitions.

Suggested change
value: (Fedora.40.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-40-helix-amd64
value: (Fedora.40.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-40-helix-amd64

Copilot uses AI. Check for mistakes.


# Oldest supported openSUSE x64 - 15.5
- name: helix_linux_x64_opensuse_oldest
value: (openSUSE.15.5.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.5-helix-amd64
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization in 'open' - should be 'Open' to match other queue definitions.

Suggested change
value: (openSUSE.15.5.Amd64.Open)AzureLinux.3.Amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.5-helix-amd64
value: (openSUSE.15.5.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-15.5-helix-amd64

Copilot uses AI. Check for mistakes.

# Use this when you want to test against the minimum supported OS versions to ensure backward compatibility.
#
# Usage in templates:
# - template: /eng/pipelines/common/helix-platforms-oldest.yml
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template path in the usage example should match the actual file location. The file is located at /eng/pipelines/helix-platforms-oldest.yml, not in a /common/ subdirectory.

Suggested change
# - template: /eng/pipelines/common/helix-platforms-oldest.yml
# - template: /eng/pipelines/helix-platforms-oldest.yml

Copilot uses AI. Check for mistakes.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants