Fix "same try" in interpreter compiler #120803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The COR_ILEXCEPTION_CLAUSE_SAMETRY was never set in the generated EH info due to a bug. I've also fixed a minor debug logging issue - fault clauses were missing in the dumped EH clauses
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Pull Request Overview
Fixes missed setting of COR_ILEXCEPTION_CLAUSE_SAMETRY in interpreter-generated EH info and adds missing debug dump output for fault handlers.
- Moves lastTry* updates after comparison so SAMETRY bit is now correctly applied.
- Adds explicit debug logging branch for fault handlers.
davidwrighton
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COR_ILEXCEPTION_CLAUSE_SAMETRY was never set in the generated EH info due to a bug.
I've also fixed a minor debug logging issue - fault clauses were missing in the dumped EH clauses