-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[ios-clr] Update Subsets.props to build CoreCLR subset for Apple mobile #120787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where the CoreCLR subset was not being built by default for Apple mobile platforms (iOS/tvOS/MacCatalyst) after CoreCLR runtime packs were enabled. The fix ensures that when CoreCLR is supported on Apple mobile devices, the clr
subset is included in the default build configuration, mirroring the approach already used for Android.
Key Changes:
- Split the Apple mobile default subset configuration into two conditions based on CoreCLR support
- Added RuntimeFlavor detection for Apple mobile when CoreCLR subset is present
- Configured DefaultCoreClrSubsets for Apple mobile platforms
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
I first pushed this change to codeflow PR dotnet/dotnet#2885, but there is currently a conflict with the latest changes in dotnet/runtime, so I opened this PR instead. @dotnet/product-construction Please let me know how to resolve the conflict - should I merge this PR and revert the commit in codeflow PR? |
@kotlarmilos merge here and then we will re-open a new one in VMR - that will be the easiest - I saw Djuradj spotted some other codeflow issues in the VMR one so we'd be doing it anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this, but for the inner loop we should try to tune RuntimeFlavor
better when building the coreclr or mono version separately. Right now it's locked and if you're on the opposite runtime, you always have to specify the property when running tests.
Description
When CoreCLR runtime packs were enabled in #120444, the
clr
subset isn't being built by default for Apple mobile targets. This issue wasn’t caught before because the CI builds are using theclr+packs
command.