Skip to content

Fix GeneratedRegex fixer to preserve multiline verbatim string patterns #120624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Restore method specifier

8dc773c
Select commit
Loading
Failed to load commit list.
Open

Fix GeneratedRegex fixer to preserve multiline verbatim string patterns #120624

Restore method specifier
8dc773c
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime failed Oct 17, 2025 in 2h 48m 18s

Build #20251017.61 had test failures

22 errors / 1 warnings

Details

Tests

  • Failed: 22 (0.00%)
  • Passed: 2,582,646 (97.99%)
  • Other: 53,025 (2.01%)
  • Total: 2,635,693

Annotations

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44 

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/faf97bf4-1b82-46a1-afbb-83dbb1ea5468/workitems/System.Text.RegularExpressions.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44 

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/faf97bf4-1b82-46a1-afbb-83dbb1ea5468/workitems/System.Text.RegularExpressions.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44 

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/5f280197-dc26-473b-9625-cb5592a844a3/workitems/System.Text.RegularExpressions.Tests/console

Check failure on line 44 in .packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets#L44 

.packages\microsoft.dotnet.helix.sdk\11.0.0-beta.25511.101\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/5f280197-dc26-473b-9625-cb5592a844a3/workitems/System.Text.RegularExpressions.Tests/console

Check failure on line 1 in System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer 

System.InvalidOperationException : Context: Iterative code fix application
content of '/0/Test0.cs' did not match. Diff shown with expected as baseline:
 using System.Text.RegularExpressions;
 
 static partial class Class
 {
     private const string foo = "bar";
-    private static Regex r1 = MyRegex();
 
     [GeneratedRegex(@"a        bar
                                         b
                                         c", RegexOptions.IgnorePatternWhitespace)]
-    private static partial Regex MyRegex();
+    private static partial Regex r1 { get; }
 }
Raw output 
   at Microsoft.CodeAnalysis.Testing.DefaultVerifier.Fail(String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/DefaultVerifier.cs:line 105
   at Microsoft.CodeAnalysis.Testing.IVerifierExtensions.EqualOrDiff(IVerifier verifier, String expected, String actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/Extensions/IVerifierExtensions.cs:line 67
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyProjectAsync(ProjectState newState, Project project, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 537
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(String language, ImmutableArray`1 analyzers, ImmutableArray`1 codeFixProviders, SolutionState oldState, SolutionState newState, Int32 numberOfIterations, Func`10 getFixedProject, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 515
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(SolutionState testState, SolutionState fixedState, SolutionState batchFixedState, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 477
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.RunImplAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 316
   at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.RunAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 172
   at System.Text.RegularExpressions.Tests.CSharpCodeFixVerifier`2.VerifyCodeFixAsync(String source, String fixedSource, ReferenceAssemblies references) in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/CSharpCodeFixVerifier`2.cs:line 32
   at System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer() in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs:line 1403
--- End of stack trace from previous location ---

Check failure on line 1 in System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer 

System.InvalidOperationException : Context: Iterative code fix application
content of '/0/Test0.cs' did not match. Diff shown with expected as baseline:
 using System.Text.RegularExpressions;
 
 static partial class Class
 {
-    private static Regex r = MyRegex();
-
     [GeneratedRegex(@"a
              b
              c", RegexOptions.IgnorePatternWhitespace)]
-    private static partial Regex MyRegex();
+    private static partial Regex r { get; }
 }
Raw output 
   at Microsoft.CodeAnalysis.Testing.DefaultVerifier.Fail(String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/DefaultVerifier.cs:line 105
   at Microsoft.CodeAnalysis.Testing.IVerifierExtensions.EqualOrDiff(IVerifier verifier, String expected, String actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/Extensions/IVerifierExtensions.cs:line 67
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyProjectAsync(ProjectState newState, Project project, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 537
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(String language, ImmutableArray`1 analyzers, ImmutableArray`1 codeFixProviders, SolutionState oldState, SolutionState newState, Int32 numberOfIterations, Func`10 getFixedProject, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 515
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(SolutionState testState, SolutionState fixedState, SolutionState batchFixedState, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 477
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.RunImplAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 316
   at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.RunAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 172
   at System.Text.RegularExpressions.Tests.CSharpCodeFixVerifier`2.VerifyCodeFixAsync(String source, String fixedSource, ReferenceAssemblies references) in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/CSharpCodeFixVerifier`2.cs:line 32
   at System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer() in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs:line 1370
--- End of stack trace from previous location ---

Check failure on line 1 in System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer 

System.InvalidOperationException : Context: Iterative code fix application
content of '/0/Test0.cs' did not match. Diff shown with expected as baseline:
 using System.Text.RegularExpressions;
 
 static partial class Class
 {
     private const string foo = "bar";
-    private static Regex r1 = MyRegex();
 
     [GeneratedRegex(@"a        bar
                                         b
                                         c", RegexOptions.IgnorePatternWhitespace)]
-    private static partial Regex MyRegex();
+    private static partial Regex r1 { get; }
 }
Raw output 
   at Microsoft.CodeAnalysis.Testing.DefaultVerifier.Fail(String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/DefaultVerifier.cs:line 105
   at Microsoft.CodeAnalysis.Testing.IVerifierExtensions.EqualOrDiff(IVerifier verifier, String expected, String actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/Extensions/IVerifierExtensions.cs:line 67
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyProjectAsync(ProjectState newState, Project project, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 537
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(String language, ImmutableArray`1 analyzers, ImmutableArray`1 codeFixProviders, SolutionState oldState, SolutionState newState, Int32 numberOfIterations, Func`10 getFixedProject, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 515
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(SolutionState testState, SolutionState fixedState, SolutionState batchFixedState, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 477
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.RunImplAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 316
   at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.RunAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 172
   at System.Text.RegularExpressions.Tests.CSharpCodeFixVerifier`2.VerifyCodeFixAsync(String source, String fixedSource, ReferenceAssemblies references) in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/CSharpCodeFixVerifier`2.cs:line 32
   at System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineStringConcatenationPreservedByFixer() in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs:line 1403
--- End of stack trace from previous location ---

Check failure on line 1 in System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer 

System.InvalidOperationException : Context: Iterative code fix application
content of '/0/Test0.cs' did not match. Diff shown with expected as baseline:
 using System.Text.RegularExpressions;
 
 static partial class Class
 {
-    private static Regex r = MyRegex();
-
     [GeneratedRegex(@"a
              b
              c", RegexOptions.IgnorePatternWhitespace)]
-    private static partial Regex MyRegex();
+    private static partial Regex r { get; }
 }
Raw output 
   at Microsoft.CodeAnalysis.Testing.DefaultVerifier.Fail(String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/DefaultVerifier.cs:line 105
   at Microsoft.CodeAnalysis.Testing.IVerifierExtensions.EqualOrDiff(IVerifier verifier, String expected, String actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/Extensions/IVerifierExtensions.cs:line 67
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyProjectAsync(ProjectState newState, Project project, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 537
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(String language, ImmutableArray`1 analyzers, ImmutableArray`1 codeFixProviders, SolutionState oldState, SolutionState newState, Int32 numberOfIterations, Func`10 getFixedProject, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 515
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.VerifyFixAsync(SolutionState testState, SolutionState fixedState, SolutionState batchFixedState, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 477
   at Microsoft.CodeAnalysis.Testing.CodeFixTest`1.RunImplAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs:line 316
   at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.RunAsync(CancellationToken cancellationToken) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 172
   at System.Text.RegularExpressions.Tests.CSharpCodeFixVerifier`2.VerifyCodeFixAsync(String source, String fixedSource, ReferenceAssemblies references) in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/CSharpCodeFixVerifier`2.cs:line 32
   at System.Text.RegularExpressions.Tests.UpgradeToGeneratedRegexAnalyzerTests.MultilineVerbatimStringPreservedByFixer() in /_/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs:line 1370
--- End of stack trace from previous location ---
View more details on Azure Pipelines