[wasm][coreclr] Fix arg iterator offset calculation and EH in part of interpreter tests #120613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for this and retbuf arguments at the beginning Add more call functions hit during EH Fixes dotnet#120318
radekdoulik
requested review from
AaronRobinsonMSFT and
jkotas
and removed request for
Copilot
|
Tagging subscribers to this area: @mangod9 |
jkotas
approved these changes
Oct 10, 2025
AaronRobinsonMSFT
approved these changes
Oct 10, 2025
This was referenced Oct 11, 2025
|
I found one more issue here, I will fix it in the followup PR |
radekdoulik
added a commit
to radekdoulik/runtime
that referenced
this pull request
Oct 13, 2025
Fixes remaining issue mentioned in dotnet#120613 This fixes offset calculation of This and other special cased arguments. Without that fix, we ended writing the this argument value to a wrong offset.
radekdoulik
added a commit
that referenced
this pull request
Oct 13, 2025
* [wasm][coreclr] Fix GetOffsetOfArgumentRegisters Fixes remaining issue mentioned in #120613 This fixes offset calculation of This and other special cased arguments. Without that fix, we ended writing the this argument value to a wrong offset. * Update src/coreclr/vm/callingconvention.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
radekdoulik
added a commit
to radekdoulik/runtime
that referenced
this pull request
Oct 14, 2025
Fixes remaining issue mentioned in dotnet#120613 This fixes offset calculation of This and other special cased arguments. Without that fix, we ended writing the this argument value to a wrong offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120318
Account for this and retbuf arguments at the beginning of offset calculation
Add more call functions hit during EH