Make BundledAppWithSubDirs clean up bundled apps after each test case instead of after all tests in the class
#120611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of after all tests
There was a problem hiding this comment.
Pull Request Overview
This PR addresses intermittent out-of-space issues in CI by changing the cleanup behavior of bundled app tests. Instead of waiting until all tests in a class finish to clean up created bundled apps, each test now cleans up its bundled app immediately after running.
- Modified cleanup timing to delete bundled apps after each test instead of after all tests complete
- Added explicit cleanup for extracted files in one test case that was missing it
- Renamed parameter from
deleteExtractedtodeleteAppto better reflect the new behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BundledAppWithSubDirs.cs | Updated RunTheApp method to delete bundled apps immediately after each test and renamed cleanup parameter |
| BundleExtractToSpecificPath.cs | Added missing cleanup for extraction directory in UndefinedHOME_getpwuidFallback test |
jtschuster
approved these changes
Oct 10, 2025
AaronRobinsonMSFT
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BundledAppWithSubDirstests intermittently hit out of space issues in CI. They do clean up the bundled apps they create, but only after all tests in the class have run. This change makes those tests clean up earlier for environments that may not have the space for all the bundled apps at the same time. This also fixes the one case where we were leaving an extracted file (mockcoreclr) behind on non-Windows.Fixes #119249
cc @dotnet/appmodel @AaronRobinsonMSFT